Remove Out Endpoint Descriptors from Absolute Mouse and Relative Mouse #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added attribute to remove unnecessary out endpoint.
Added attribute to remove unnecessary out endpoint.
Added attribute to explicitly keep currently needed out endpoint and to make listed attributes consistent across the keyboard and mouse devices.
Contributor
Author
|
Just to clarify, this pull-request only removes the out endpoint from the absolute mouse and the relative mouse devices. It does not remove the out endpoint from the keyboard since this is still currently needed to maintain led synchronization with the browser. This pull-request does list the attribute for all three devices for the sake of consistency. |
Contributor
Author
|
@ym - Do I need to do anything to get this code merged? |
ym
approved these changes
Jul 11, 2025
adammkelly
pushed a commit
to adammkelly/kvm
that referenced
this pull request
Jul 15, 2025
jetkvm#542) * Update hid_mouse_absolute.go Added attribute to remove unnecessary out endpoint. * Update hid_mouse_relative.go Added attribute to remove unnecessary out endpoint. * Update hid_keyboard.go Added attribute to explicitly keep currently needed out endpoint and to make listed attributes consistent across the keyboard and mouse devices. --------- Co-authored-by: Aveline <352441+ym@users.noreply.github.com>
adammkelly
pushed a commit
to adammkelly/kvm
that referenced
this pull request
Jul 15, 2025
jetkvm#542) * Update hid_mouse_absolute.go Added attribute to remove unnecessary out endpoint. * Update hid_mouse_relative.go Added attribute to remove unnecessary out endpoint. * Update hid_keyboard.go Added attribute to explicitly keep currently needed out endpoint and to make listed attributes consistent across the keyboard and mouse devices. --------- Co-authored-by: Aveline <352441+ym@users.noreply.github.com>
ym
added a commit
to ym/jetkvm-kvm
that referenced
this pull request
Sep 26, 2025
jetkvm#542) * Update hid_mouse_absolute.go Added attribute to remove unnecessary out endpoint. * Update hid_mouse_relative.go Added attribute to remove unnecessary out endpoint. * Update hid_keyboard.go Added attribute to explicitly keep currently needed out endpoint and to make listed attributes consistent across the keyboard and mouse devices. --------- Co-authored-by: Aveline <352441+ym@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added attribute to remove unnecessary and potentially confusing out endpoint descriptors from the absolute mouse and relative mouse. Also added same attribute to keyboard (albeit with the opposite value) to explicitly keep currently needed out endpoint descriptor to make listed attributes consistent across the keyboard and mouse devices.